waf: enable cross-compilation support #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
changed the title
|
@cpaelzer iirc you wrote this plugin originally, mind taking a quick look? |
cpaelzer
reviewed
Jul 11, 2017
| ]) | ||
| return env | ||
|
|
||
| def enable_cross_compilation(self): |
There was a problem hiding this comment.
Something still missing - if so drop this and line 160.
Otherwise I think a comment why it is there for people like me would be very kind.
|
Other than the comment above LGTM, I have nothing around to test it. |
sergiusens
reviewed
Jul 12, 2017
| @@ -14,10 +14,25 @@ | |||
| # You should have received a copy of the GNU General Public License | |||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
|
|
|||
| import os | |||
|
|
|||
come-maiz
reviewed
Jul 18, 2017
There was a problem hiding this comment.
Thanks @kalikiana! But well, this also need the steps in manual_tests.md, so we don't forget about it.
come-maiz
approved these changes
Jul 21, 2017
kalikiana
added a commit
to kalikiana/snapcraft
that referenced
this pull request
Aug 3, 2017
kalikiana
added a commit
to kalikiana/snapcraft
that referenced
this pull request
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC and CXX environment variables need to be set accordingly to cross-compile with Waf.