Quassel GUI in snap #297
Open
Quassel GUI in snap #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sput42
reviewed
Sep 4, 2017
| command: wrap quasselcore --syslog | ||
| plugs: [network-bind] | ||
| daemon: simple | ||
| quassel-kalikiana: |
There was a problem hiding this comment.
Is this correct? I.e. should your nickname be referenced here, or did you mean to have just "quassel" here? I know nothing about snaps :)
Sput42
reviewed
Sep 4, 2017
| @@ -0,0 +1,45 @@ | |||
| name: quassel | |||
| version: "0.13-pre" | |||
There was a problem hiding this comment.
Do you know of any way to extract this value from CMAKE or another file? I don't like having the version specified in multiple places...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Quassel Qt5 GUI to the snap.
Move files into a snap folder.