Add OpenStackIdentity_3_0_Connection child class to manage auth with OpenID access tokens #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I will look into it shorty. In the mean time, would it be possible to add some tests for this new authentication method? |
|
@Kami I have added tests for the new authentication method. |
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
Closes #789 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
|
Thanks and sorry for the delay. The changes look good to me so I went ahead and merged them into trunk. When you get a chance it would also be great if you can add some documentation on how to authenticate against OpenStack based clouds using a token. Also, since this is a bigger change, can you please also file an ICLA - https://libcloud.readthedocs.io/en/latest/development.html#contributing-bigger-changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OpenStackIdentity_3_0_Connection child class to manage auth with OpenID access tokens
Description
The class OpenStackIdentity_3_0_Connection_OIDC_access_token has been added to enable OpenStack driver to manage OpenID access tokens to get access to an OpenStack site.
http://docs.openstack.org/developer/keystone/extensions/openidc.html
Status
Checklist (tick everything that applies)