Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1032063002: Enable 'First-Party-Only' cookies by default. (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable 'First-Party-Only' cookies by default. This patch reverts https://codereview.chromium.org/940373002, and adds back in the ~2 lines and tests that are still relevant. BUG=459154 Committed: https://crrev.com/bdd0b09b5371066ad6d6c0ef2c32f5b92595316d Cr-Commit-Position: refs/heads/master@{#322533}

Patch Set 1 #

Patch Set 2 : Test. #

Total comments: 1

Patch Set 3 : Friend. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -170 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 5 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_network_delegate.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M net/base/layered_network_delegate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M net/base/network_delegate.h View 2 chunks +0 lines, -11 lines 0 comments Download
M net/base/network_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M net/url_request/url_request_test_util.h View 3 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
Mike West
Hi Ryan, Chris, and Jochen. Assuming that the patch is correct, what is the right ...
5 years, 9 months ago (2015-03-25 08:36:10 UTC) #2
jochen (gone - plz use gerrit)
me + somebody from the network stack team
5 years, 9 months ago (2015-03-25 12:25:49 UTC) #3
Mike West
On 2015/03/25 at 12:25:49, jochen wrote: > me + somebody from the network stack team ...
5 years, 9 months ago (2015-03-25 15:32:34 UTC) #4
cbentzel
On 2015/03/25 15:32:34, Mike West wrote: > On 2015/03/25 at 12:25:49, jochen wrote: > > ...
5 years, 9 months ago (2015-03-26 05:42:23 UTC) #5
Mike West
On 2015/03/26 at 05:42:23, cbentzel wrote: > From a code review perspective I am becoming ...
5 years, 9 months ago (2015-03-26 07:30:20 UTC) #6
jochen (gone - plz use gerrit)
the bots don't like it?
5 years, 9 months ago (2015-03-26 15:38:29 UTC) #7
Mike West
On 2015/03/26 at 15:38:29, jochen wrote: > the bots don't like it? This is what ...
5 years, 9 months ago (2015-03-26 15:42:15 UTC) #8
jochen (gone - plz use gerrit)
lgtm for the green patchset
5 years, 9 months ago (2015-03-26 15:42:50 UTC) #9
cbentzel
On 2015/03/26 15:42:50, jochen wrote: > lgtm for the green patchset Happy with patch once ...
5 years, 9 months ago (2015-03-26 21:03:12 UTC) #10
Mike West
I'm pretty sure the latest patch will compile. I forgot to unrevert a friended class' ...
5 years, 9 months ago (2015-03-26 21:11:59 UTC) #11
cbentzel
On 2015/03/26 21:11:59, Mike West wrote: > I'm pretty sure the latest patch will compile. ...
5 years, 9 months ago (2015-03-26 21:48:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032063002/40001
5 years, 9 months ago (2015-03-27 04:59:26 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-27 05:03:40 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bdd0b09b5371066ad6d6c0ef2c32f5b92595316d Cr-Commit-Position: refs/heads/master@{#322533}
5 years, 9 months ago (2015-03-27 05:04:38 UTC) #17
Mike West
5 years, 8 months ago (2015-04-01 05:52:11 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1043403003/ by mkwst@chromium.org.

The reason for reverting is: Blink OWNERs would like to wait a bit before
shipping:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wKZBCzcNssg/nZ1CFmgd....

Powered by Google App Engine
This is Rietveld 408576698